[YUNIKORN-2205] remove the warning of processing nonexistent "namespa… #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #747 +/- ##
==========================================
+ Coverage 69.43% 69.51% +0.07%
==========================================
Files 50 50
Lines 7993 7994 +1
==========================================
+ Hits 5550 5557 +7
+ Misses 2254 2249 -5
+ Partials 189 188 -1 ☔ View full report in Codecov by Sentry. |
pbacsko
requested changes
Dec 7, 2023
pbacsko
reviewed
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The warning message is printed when "namespace.guaranteed" does not exist. This PR checking if the "namespaceGuaranteed" value is empty and returning early to avoid the warning message. This ensures that the warning is not displayed when the expected behavior occurs.
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2205